[
https://issues.apache.org/jira/browse/HDFS-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434606#comment-13434606
]
Aaron T. Myers commented on HDFS-3799:
--------------------------------------
Patch looks really good. The tests in particular are very solid. Two nits:
# sp: "Synchronziing"
# Recommend replacing the three "testOutOfSyncAtBeginningOfSegmentX" methods
with a loop from 0-2. Feel free to punt if you think this is clearer.
+1 once these are addressed.
> QJM: handle empty log segments during recovery
> ----------------------------------------------
>
> Key: HDFS-3799
> URL: https://issues.apache.org/jira/browse/HDFS-3799
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: QuorumJournalManager (HDFS-3077)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-3799.txt
>
>
> One of the cases not yet handled in the QJM branch is the one where either
> the writer or the journal node crashes after startLogSegment() but before it
> has written its first transaction to the log. We currently have TODO
> assertions in the code which fire in these cases.
> This JIRA is to deal with these cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
