[ 
https://issues.apache.org/jira/browse/HDFS-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434633#comment-13434633
 ] 

Aaron T. Myers commented on HDFS-3800:
--------------------------------------

Test looks great, and I agree we should go ahead and check it in to the branch 
as-is.

One tiny nit: looks like you left in a System.out.println when we should 
probably have used a LOG.info.

+1 otherwise.
                
> QJM: improvements to QJM fault testing
> --------------------------------------
>
>                 Key: HDFS-3800
>                 URL: https://issues.apache.org/jira/browse/HDFS-3800
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: QuorumJournalManager (HDFS-3077)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-3800.txt
>
>
> This JIRA improves TestQJMWithFaults as follows:
> - the current implementation didn't properly unwrap exceptions thrown by the 
> reflection-based injection method. This caused some issues in the code where 
> the injecting proxy didn't act quite like the original object.
> - the current implementation incorrectly assumed that the recovery process 
> would recover to _exactly_ the last acked sequence number. In fact, it may 
> recover to that transaction _or any greater transaction_.
> It also adds a new randomized test which uncovered a number of other bugs. I 
> will defer to the included javadoc for a description of this test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to