[
https://issues.apache.org/jira/browse/HDFS-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434702#comment-13434702
]
Todd Lipcon commented on HDFS-3793:
-----------------------------------
Fixed the two nits and committed to branch. Thanks.
bq. Seems like you should make the QuorumJournalManager#format and
QuroumJournalManager#hasSomeData timeouts configurable, or at least use
constants and add a comment or two justifying how you chose those values.
I added constants and set them both to 60sec. Also added a comment explaining
that, since they are only used in format and not normal operation, we can use a
fairly long timeout and don't really need to configure them (if a user sees a
timeout they can manually investigate why it's taking 60+sec and do something
about it)
bq. I think I see the reasoning behind the need for the call to unlockAll in
JNStorage#format, but you might want to add a comment explaining why it's
necessary. Also, if this happens, when will the storage be locked again? Might
want to add a comment explaining that as well.
Added a comment:
{code}
// Unlock the directory before formatting, because we will
// re-analyze it after format(). The analyzeStorage() call
// below is reponsible for re-locking it. This is a no-op
// if the storage is not currently locked.
unlockAll();
{code}
> Implement genericized format() in QJM
> -------------------------------------
>
> Key: HDFS-3793
> URL: https://issues.apache.org/jira/browse/HDFS-3793
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: QuorumJournalManager (HDFS-3077)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-3793.txt
>
>
> HDFS-3695 added the ability for non-File journal managers to tie into calls
> like NameNode -format. This JIRA is to implement format() for
> QuorumJournalManager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
