[ 
https://issues.apache.org/jira/browse/HDFS-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434889#comment-13434889
 ] 

Hudson commented on HDFS-3802:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2607 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2607/])
    HDFS-3802. StartupOption.name in HdfsServerConstants should be final.  
Contributed by Jing Zhao (Revision 1373253)

     Result = FAILURE
szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373253
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java

                
> StartupOption.name in HdfsServerConstants should be final
> ---------------------------------------------------------
>
>                 Key: HDFS-3802
>                 URL: https://issues.apache.org/jira/browse/HDFS-3802
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Trivial
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3802.patch
>
>
> In HdfsServerConstants, it may be better to define StartupOption.name as 
> final since it will not and should not be modified after initialization. For 
> example, in NameNode.java, the printUsage function prints out multiple 
> startup options' names. The modification/change of the StartupOption.name may 
> cause invalid usage message. Although right now there is no methods to 
> change/set the value of StartupOption.name, it is better to add the final 
> keyword to make sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to