[ https://issues.apache.org/jira/browse/HDFS-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435472#comment-13435472 ]
Hudson commented on HDFS-3796: ------------------------------ Integrated in Hadoop-Common-trunk-Commit #2581 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2581/]) HDFS-3796. Speed up edit log tests by avoiding fsync(). Contributed by Todd Lipcon. (Revision 1373567) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373567 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogFileOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRecovery.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSecurityTokenEditLog.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogsDuringFailover.java > Speed up edit log tests by avoiding fsync() > ------------------------------------------- > > Key: HDFS-3796 > URL: https://issues.apache.org/jira/browse/HDFS-3796 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 3.0.0, 2.2.0-alpha > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Fix For: 3.0.0, 2.2.0-alpha > > Attachments: hdfs-3796.txt, hdfs-3796.txt > > > Our edit log tests are very slow because they incur a lot of fsyncs as they > write out transactions. Since fsync() has no effect except in the case of > power outages or system crashes, and we don't care about power outages in the > context of tests, we can safely skip the fsync without any loss in coverage. > In my tests, this sped up TestEditLog by about 5x. The testFuzzSequences test > case improved from ~83 seconds with fsync to about 5 seconds without. These > results are from my SSD laptop - they are probably even more drastic on > spinning media. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira