[ https://issues.apache.org/jira/browse/HDFS-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439252#comment-13439252 ]
Hadoop QA commented on HDFS-3832: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541847/HDFS-3832.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3062//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3062//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3062//console This message is automatically generated. > Remove protocol methods related to DistributedUpgrade > ----------------------------------------------------- > > Key: HDFS-3832 > URL: https://issues.apache.org/jira/browse/HDFS-3832 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, name-node > Affects Versions: 3.0.0 > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Attachments: HDFS-3832.patch, HDFS-3832.patch > > > As part of further DistributedUpgrade code deletion, this jira proposes to > remove ClientProtocol#distributedUpgradeProgress() and > ClientProtocol#processUpgradeCommand > * related protobuf methods, requests and responses > * related java methods, request and responses > These are non-compatible changes. It should be okay to delete them, because > this functionality has not been used for a long time(last used in 0.14) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira