[ https://issues.apache.org/jira/browse/HDFS-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439852#comment-13439852 ]
Andy Isaacson commented on HDFS-3828: ------------------------------------- bq. It looks like the following code in BlockPoolSliceScanner#scan was intended to regular the interval, but per HDFS-3194 doesn't work because the call to cleanUp() rolls the log Hmmm, interesting. As things currently stand, when we're erroneously re-scanning, the while loop in {{scan()}} ends up calling {{verifyFirstBlock()}} because {{getEarliestScanTime()}} depends on the dncp log. So I like your idea to move the test into cleanUp and rename cleanUp. It seems to have the right behavior too. New patch coming up. > Block Scanner rescans blocks too frequently > ------------------------------------------- > > Key: HDFS-3828 > URL: https://issues.apache.org/jira/browse/HDFS-3828 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.23.0, 2.0.0-alpha > Reporter: Andy Isaacson > Assignee: Andy Isaacson > Attachments: hdfs3828.txt > > > Branching off from HDFS-3194: > Andy said: > {quote} > There is still an issue here even with the patch from hdfs-3194-1.txt. > Running on a cluster with just one block we now see > {noformat} > 2012-08-16 15:59:57,884 INFO datanode.BlockPoolSliceScanner > (BlockPoolSliceScanner.java:verifyBlock(391)) - Verification succeeded for > BP-2101131164-172.29.122.91-1337906886255:blk_7919273167187535506_4915 > 2012-08-16 16:00:07,904 INFO datanode.BlockPoolSliceScanner > (BlockPoolSliceScanner.java:verifyBlock(391)) - Verification succeeded for > BP-2101131164-172.29.122.91-1337906886255:blk_7919273167187535506_4915 > 2012-08-16 16:00:17,925 INFO datanode.BlockPoolSliceScanner > (BlockPoolSliceScanner.java:verifyBlock(391)) - Verification succeeded for > BP-2101131164-172.29.122.91-1337906886255:blk_7919273167187535506_4915 > {noformat} > {quote} > Uma said: > bq. Latest patch from Amith should address this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira