[
https://issues.apache.org/jira/browse/HDFS-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443289#comment-13443289
]
Suresh Srinivas commented on HDFS-3860:
---------------------------------------
Thanks Aaron for committing the patch.
bq. BTW could you please also ensure that this pattern of code is not repeated
in any other places.
Going back to my previous comment, Jing, if possible can you also see if there
other such issues.
> HeartbeatManager#Monitor may wrongly hold the writelock of namesystem
> ---------------------------------------------------------------------
>
> Key: HDFS-3860
> URL: https://issues.apache.org/jira/browse/HDFS-3860
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Fix For: 2.2.0-alpha
>
> Attachments: HDFS-3860.patch, HDFS-heartbeat-testcase.patch
>
>
> In HeartbeatManager#heartbeatCheck, if some dead datanode is found, the
> monitor thread will acquire the write lock of namesystem, and recheck the
> safemode. If it is in safemode, the monitor thread will return from the
> heartbeatCheck function without release the write lock. This may cause the
> monitor thread wrongly holding the write lock forever.
> The attached test case tries to simulate this bad scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
