[
https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450118#comment-13450118
]
Aaron T. Myers commented on HDFS-3896:
--------------------------------------
Patch looks pretty good to me, Jeff. A few little comments:
# I'd recommend removing the line about "if the port is 0..." from the namenode
http-address config. Even if that's technically true, users really shouldn't be
doing that, since they then won't be able to find the NN web UI, and the 2NN
won't be able to checkpoint since it needs to know the HTTP address of the NN.
# In general I think I'd replace the word "server" with "address" in your
patch, e.g. "RPC address for HDFS..." instead of "RPC server for HDFS...".
# This sentence doesn't really parse: "In the case of HA/Federation where
multiple namenodes exist. The suffix of the namenode service id is added to the
name e.g. dfs.namenode.rpc-address.ns1 dfs.namenode.rpc-address.<NameServiceID>"
# You might want to mention in the description for servicerpc-address that the
value of the rpc-address will be used as the default if the servicerpc-address
is unset.
> Add place holder for dfs.namenode.rpc-address and
> dfs.namenode.servicerpc-address to hdfs-default.xml
> -----------------------------------------------------------------------------------------------------
>
> Key: HDFS-3896
> URL: https://issues.apache.org/jira/browse/HDFS-3896
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Jeff Lord
> Attachments: hdfs-default.patch
>
>
> Currently there are mentions of these properties in the docs but not much
> else.
> Would make sense to have empty place holders in hdfs-default.xml to clarify
> where they go and what they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
