[ https://issues.apache.org/jira/browse/HDFS-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452524#comment-13452524 ]
Andy Isaacson commented on HDFS-3910: ------------------------------------- LGTM. I might name the variable {{correctReplicas}} rather than {{sufficientReplicas}} since it is {{false}} when replFactor=2 and locs.length=3, but that is a minor point. > DFSTestUtil#waitReplication should timeout > ------------------------------------------ > > Key: HDFS-3910 > URL: https://issues.apache.org/jira/browse/HDFS-3910 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 2.0.0-alpha > Reporter: Eli Collins > Assignee: Eli Collins > Attachments: hdfs-3910.txt > > > DFSTestUtil#waitReplication never times out so test execution fails only when > the mvn test executor times out. This leaves a stray test process around, an > example is HDFS-3902. Let's make waitReplication do something like bail after > it has checked block locations 10 times for one file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira