[ 
https://issues.apache.org/jira/browse/HDFS-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453585#comment-13453585
 ] 

Eli Collins commented on HDFS-3664:
-----------------------------------

Change looks good. And the test failures look unrelated, 
TestDatanodeBlockScanner is known and looks like its still running java process 
is locking the storage dir causing TestDatanodeBlockScanner to fail. I verified 
TestBlockMissingException with your patch for sanity.

Not your change but in BlockManager we should check datanodeManager and 
blocksMap for null like we do pendingReplications right?

                
> BlockManager race when stopping active services
> -----------------------------------------------
>
>                 Key: HDFS-3664
>                 URL: https://issues.apache.org/jira/browse/HDFS-3664
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-3664.001.patch
>
>
> Looks like there's a race hit by the test where we try to do block management 
> while shutting down (eg allocate a block or compute replication work after 
> BlocksMap#close, resulting in an NPE).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to