[ https://issues.apache.org/jira/browse/HDFS-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453678#comment-13453678 ]
Hadoop QA commented on HDFS-3916: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544749/HDFS-3916.005.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDatanodeBlockScanner org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3177//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3177//console This message is automatically generated. > libwebhdfs (C client) code cleanups > ----------------------------------- > > Key: HDFS-3916 > URL: https://issues.apache.org/jira/browse/HDFS-3916 > Project: Hadoop HDFS > Issue Type: Bug > Components: webhdfs > Affects Versions: 3.0.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: 0002-fix.patch, HDFS-3916.003.patch, > HDFS-3916.004.patch, HDFS-3916.005.patch > > > Code cleanups in libwebhdfs. > * don't duplicate exception.c, exception.h, expect.h, jni_helper.c. We have > one copy of these files; we don't need 2. > * remember to set errno in all public library functions (this is part of the > API) > * fix undefined symbols (if a function is not implemented, it should return > ENOTSUP, but still exist) > * don't expose private data structures in the (end-user visible) public > headers > * can't re-use hdfsBuilder as hdfsFS, because the strings in hdfsBuilder are > not dynamically allocated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira