[
https://issues.apache.org/jira/browse/HDFS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459201#comment-13459201
]
Hadoop QA commented on HDFS-3957:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545818/hdfs-3957-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in
hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3216//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3216//console
This message is automatically generated.
> Change MutableQuantiles to use a shared thread for rolling over metrics
> -----------------------------------------------------------------------
>
> Key: HDFS-3957
> URL: https://issues.apache.org/jira/browse/HDFS-3957
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.3-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Minor
> Attachments: hdfs-3957-1.patch, hdfs-3957-2.patch
>
>
> Each MutableQuantiles currently creates its own thread to rollover the
> histogram every interval. It'd be better to do this with a single, shared
> thread or executor, and do it with a ThreadFactory that names it properly.
> Similar changes were made when porting MutableQuantiles to HBase in
> HBASE-6409, so this would also help keep them in sync.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
