[ https://issues.apache.org/jira/browse/HDFS-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462496#comment-13462496 ]
Hadoop QA commented on HDFS-3969: --------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546427/hdfs-3969.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3229//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3229//console This message is automatically generated. > Small bug fixes and improvements for disk locations API > ------------------------------------------------------- > > Key: HDFS-3969 > URL: https://issues.apache.org/jira/browse/HDFS-3969 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client > Affects Versions: 3.0.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hdfs-3969.txt > > > The new disk block locations API has a configurable timeout, but it's used > inconsistently: the invokeAll() call to the thread pool assumes the timeout > is in seconds, but the RPC timeout is set in milliseconds. > Also, we can improve the wire protocol for this API to be a lot more > efficient. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira