[ https://issues.apache.org/jira/browse/HDFS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469944#comment-13469944 ]
Colin Patrick McCabe commented on HDFS-3920: -------------------------------------------- Oh yeah, I was going to mention, but I forgot: there are a few places where you {{malloc}}ing small strings that really should just go on the stack. I think you'll find that in a lot of cases, it's a lot simpler just to put them on the stack. > libwebdhfs code cleanup: string processing and using strerror consistently to > handle all errors > ----------------------------------------------------------------------------------------------- > > Key: HDFS-3920 > URL: https://issues.apache.org/jira/browse/HDFS-3920 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-3920-001.patch, HDFS-3920-001.patch, > HDFS-3920-002.patch, HDFS-3920-003.patch, HDFS-3920-004.patch, > HDFS-3920-005.patch > > > 1. Clean up code for string processing; > 2. Using strerror consistently for error handling; > 3. Use sprintf to replace decToOctal > 4. other issues requiring fixing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira