[
https://issues.apache.org/jira/browse/HDFS-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473761#comment-13473761
]
Hadoop QA commented on HDFS-4033:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548664/hdfs-4033.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3304//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3304//console
This message is automatically generated.
> Miscellaneous findbugs 2 fixes
> ------------------------------
>
> Key: HDFS-4033
> URL: https://issues.apache.org/jira/browse/HDFS-4033
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-4033.txt
>
>
> Fix some miscellaneous findbugs 2 warnings:
> - Switch statements missing default cases
> - Using \n instead of %n in format methods
> - A socket close that should use IOUtils#closeSocket that we missed
> - A use of SimpleDateFormat that is not threadsafe
> - In ReplicaInputStreams it's not clear that we always close the streams we
> allocate, moving the stream creation into the class where we close them makes
> that more obvious
> - A couple missing null checks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
