[ 
https://issues.apache.org/jira/browse/HDFS-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun C Murthy closed HDFS-3485.
-------------------------------

    
> DataTransferThrottler will over-throttle when currentTimeMillis jumps
> ---------------------------------------------------------------------
>
>                 Key: HDFS-3485
>                 URL: https://issues.apache.org/jira/browse/HDFS-3485
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>            Priority: Minor
>             Fix For: 2.0.2-alpha
>
>         Attachments: hdfs-3485.1.patch, hdfs-3485-2.patch, hdfs-3485.patch
>
>
> When the system clock is set backwards, DataTransferThrottler will simply 
> pause until the clock reaches the end of the previously calculated transfer 
> period:
> {code}
>     this.curPeriodStart = System.currentTimeMillis();
> ...
>     while (curReserve <= 0) {
>       long now = System.currentTimeMillis();
>       long curPeriodEnd = curPeriodStart + period;
>       if ( now < curPeriodEnd ) {
>         try {
>           wait( curPeriodEnd - now );
> {code}
> Instead of using currentTimeMillis() which is affected by 
> system-clock-changes, this code should use nanoTime which ticks forward 
> monotonically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to