[
https://issues.apache.org/jira/browse/HDFS-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476610#comment-13476610
]
Hadoop QA commented on HDFS-4058:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549225/hdfs-4058.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3337//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3337//console
This message is automatically generated.
> DirectoryScanner may fail with IOOB if the directory scanning threads return
> out of volume order
> ------------------------------------------------------------------------------------------------
>
> Key: HDFS-4058
> URL: https://issues.apache.org/jira/browse/HDFS-4058
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-4058.txt
>
>
> The DirectoryScanner may fail with an IOOB if the directory scanning threads
> return out of volume order (ie volume scanner #3 returns before volume
> scanner #2). This is because it's using an ArrayList and ArrayList#add(index,
> element) throws IOOB if idx >= size, and size is only increased as elements
> are added, therefore adds have to be done in index order. Since we know the
> size when we create the ArrayList let's just use an array (perhaps an
> ArrayList was used originally because someone thought array creation called
> the default constructor?).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
