[ 
https://issues.apache.org/jira/browse/HDFS-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481005#comment-13481005
 ] 

Suresh Srinivas commented on HDFS-4087:
---------------------------------------

# SnapshotInfo.java
#* Make the member variables final
#* Is default constructor required?
# listSnapshots may be a better method name for methods listSnap and 
listSnapshot
# Some empty line changes in hdfs.proto can be removed

BTW this patch does not compile. You may want to leave the listSnap call out 
and add a TODO and wait for Nicholas to complete that part of the work.
                
> provide a class to save snapshot descriptions and protocol change for 
> listSnapshot
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-4087
>                 URL: https://issues.apache.org/jira/browse/HDFS-4087
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: Snapshot (HDFS-2802)
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-4087.patch, HDFS-4087.patch
>
>
> SnapInfo saves information about a snapshot. This jira also updates the java 
> protocol classes and translation for listSnapshot operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to