[ https://issues.apache.org/jira/browse/HDFS-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488542#comment-13488542 ]
Suresh Srinivas commented on HDFS-4133: --------------------------------------- First time around I did not understand the prepareModifications method. It is pretty clever. Thanks for documenting the loop. +1 for the patch. > Add testcases for testing basic snapshot functionalities > -------------------------------------------------------- > > Key: HDFS-4133 > URL: https://issues.apache.org/jira/browse/HDFS-4133 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: data-node, name-node > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-4133.001.patch, HDFS-4133-test.002.patch, > HDFS-4133-test.002.patch > > > Add testcase for basic snapshot functionalities. In the test we keep creating > snapshots, modifying original files, and check previous snapshots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira