[ 
https://issues.apache.org/jira/browse/HDFS-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490813#comment-13490813
 ] 

Suresh Srinivas commented on HDFS-4151:
---------------------------------------

Minort comment - FSNamesystem#allocateBlock() - javadoc @param needs to be 
updated from "inodes" to "inodesInPath". Otherwise the patch looks good.

                
> Passing INodesInPath instead of INode[] in FSDirectory
> ------------------------------------------------------
>
>                 Key: HDFS-4151
>                 URL: https://issues.apache.org/jira/browse/HDFS-4151
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4151_20121104.patch
>
>
> Currently, many methods in FSDirectory pass INode[] as a parameter.  It is 
> better to pass INodesInPath so that we can add more path information later 
> on.  This is especially useful in Snapshot implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to