[ https://issues.apache.org/jira/browse/HDFS-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498410#comment-13498410 ]
Tsz Wo (Nicholas), SZE commented on HDFS-4187: ---------------------------------------------- Thanks for working on this. Some comments: - Let's also add a test case for decreasing replication. - The first and the second of the assertEquals are respectively the expected value and the actual value. It is better to follow the convention. > Add testcases for replication handling in snapshots > --------------------------------------------------- > > Key: HDFS-4187 > URL: https://issues.apache.org/jira/browse/HDFS-4187 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: data-node, name-node > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-4187.001.patch > > > Add testcases for HDFS-4078, i.e., to test INodeFile#getFileReplication() and > INodeFileWithLink#getBlockReplication(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira