[ 
https://issues.apache.org/jira/browse/HDFS-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498773#comment-13498773
 ] 

Hudson commented on HDFS-4186:
------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #437 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/437/])
    HDFS-4186. logSync() is called with the write lock held while releasing 
lease (Revision 1409994)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409994
Files : 
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java

                
> logSync() is called with the write lock held while releasing lease
> ------------------------------------------------------------------
>
>                 Key: HDFS-4186
>                 URL: https://issues.apache.org/jira/browse/HDFS-4186
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.4, 2.0.2-alpha
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.5, 0.23.6
>
>         Attachments: 
> hdfs-4186-branch-0.23-inaccurate-batched-sync-count.patch, 
> hdfs-4186-trunk.patch, hdfs-4186-trunk-skip-standbyException.patch
>
>
> As pointed out in HDFS-4138, when the lease monitor calls 
> internalReleaseLease(), it acquires the namespace write lock. Inside 
> internalReleaseLease(), if a block recovery is needed, the lease is 
> reassigned to the namenode itself and this is logged & synced in 
> logReassignLease().
> Since this is done while the write lock is held, log syncing is blocked. When 
> a large number of leases are expired and blocks are recovered, namenode can 
> slow down.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to