[ 
https://issues.apache.org/jira/browse/HDFS-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499221#comment-13499221
 ] 

Aaron T. Myers commented on HDFS-4196:
--------------------------------------

I don't *think* that will be a problem, as nothing that changes the actual 
INode structures should be grabbing the FSDir lock without also grabbing the 
FSNS lock. But regardless, it shouldn't hurt to over-lock the FSDir in this 
situation.

Then how about this for the locking structure of snapshot operations:

# Lock the FSNS lock in FSNS before calling into SnapshotManager methods.
# Lock the FSDir lock in the SnapshotManager methods themselves.

How does this sound?
                
> Support renaming of snapshots
> -----------------------------
>
>                 Key: HDFS-4196
>                 URL: https://issues.apache.org/jira/browse/HDFS-4196
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4196.001.patch, HDFS-4196.002.patch, 
> HDFS-4196.003.patch
>
>
> Add the functionality of renaming an existing snapshot with a given new name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to