[ 
https://issues.apache.org/jira/browse/HDFS-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501505#comment-13501505
 ] 

Colin Patrick McCabe commented on HDFS-4214:
--------------------------------------------

It's already logged by this code in OfflineEditsViewer:

{code}
    ...
    } catch(Exception e) {
      System.err.println("Encountered exception. Exiting: " + e.getMessage());
      e.printStackTrace(System.err);
      return -1;
    }
    ...
{code}

I guess arguably that should catch {{Throwable}}.  But even if that doesn't 
happen, Java would just bubble the exception up to the top level and print it 
to stderr.
                
> OfflineEditsViewer should print out the offset at which it encountered an 
> error
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-4214
>                 URL: https://issues.apache.org/jira/browse/HDFS-4214
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>         Attachments: HDFS-4214.001.patch
>
>
> OfflineEditsViewer should print out the offset at which it encountered an 
> error.  This helps developers or users debug problems with loading malformed 
> logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to