[
https://issues.apache.org/jira/browse/HDFS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501549#comment-13501549
]
Tsz Wo (Nicholas), SZE commented on HDFS-4209:
----------------------------------------------
> FSDirectory.java - Reading the namenode cache threshold is moved? There is
> also call to reset(). The need for this is not obvious to me.
I want to reuse the code for creating the root so that I use reset(). It is
probably better to create a new createRoot method.
> Clean up FSDirectory and INode
> ------------------------------
>
> Key: HDFS-4209
> URL: https://issues.apache.org/jira/browse/HDFS-4209
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4209_20121118b.patch, h4209_20121118.patch,
> h4209_20121119.patch
>
>
> - FSDirectory.addToParent(..) is only used by image loading so that
> synchronization, modification time update and space count update are not
> needed.
> - There are multiple places checking whether an inode is file by checking
> !isDirectory() && !isSymlink(). Let's add isFile() to INode.
> - In the addNode/addChild/addChildNoQuotaCheck methods, returning the same
> INode back is not useful. It is better to simply return a boolean to
> indicate whether the inode is added. Also, the value of childDiskspace
> parameter is always UNKNOWN_DISK_SPACE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
