[jira] [Commented] (HDFS-4219) Port slive to branch-1

[Arpit Gupta (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501670#comment-13501670
 ] 

Arpit Gupta commented on HDFS-4219:
-----------------------------------

It was a straight forward port by taking the code from trunk 
(hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/slive)
 to branch-1. Had to change SliveMapper.java

{code}
if(conf.get(MRJobConfig.TASK_ATTEMPT_ID) != null ) {
      this.taskId = TaskAttemptID.forName(conf.get(MRJobConfig.TASK_ATTEMPT_ID))
        .getTaskID().getId();
    } else {
      // So that branch-1/0.20 can run this same code as well
      this.taskId = TaskAttemptID.forName(conf.get("mapred.task.id"))
          .getTaskID().getId();
    }

{code}

and remove the if/else block and just make it

{code}
this.taskId = TaskAttemptID.forName(conf.get("mapred.task.id"))
          .getTaskID().getId();
{code}

As the MRJobConfig is not available in branch-1
                
> Port slive to branch-1
> ----------------------
>
>                 Key: HDFS-4219
>                 URL: https://issues.apache.org/jira/browse/HDFS-4219
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 1.1.0
>            Reporter: Arpit Gupta
>            Assignee: Arpit Gupta
>         Attachments: HDFS-4219.branch-1.patch
>
>
> Originally it was committed in HDFS-708 and MAPREDUCE-1804

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira