[ 
https://issues.apache.org/jira/browse/HDFS-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507418#comment-13507418
 ] 

Jing Zhao commented on HDFS-4243:
---------------------------------

"by removing unnecessary FSNamesystem locking" -- I mean remove unnecessary 
fsdir locking. But to provide an unprotected version of replaceNode for the 
call in applyEditLogOp should be better.
                
> INodeDirectory.replaceChild(..) does not update parent
> ------------------------------------------------------
>
>                 Key: HDFS-4243
>                 URL: https://issues.apache.org/jira/browse/HDFS-4243
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Jing Zhao
>         Attachments: HDFS-4243.001.patch
>
>
> The method replaces an existing child with a new child.  However, it does not 
> take care the case the child also an INodeDirectory.  In such case, the 
> parent pointers of the children of the child have to be updated to the new 
> child.
> Only FSDirectory.unprotectedSetQuota(..) calls this method so that the child 
> is always an INodeDirectory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to