[ https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510281#comment-13510281 ]
Konstantin Boudnik commented on HDFS-4268: ------------------------------------------ +1 patch looks good. > Remove redundant enum NNHAStatusHeartbeat.State > ----------------------------------------------- > > Key: HDFS-4268 > URL: https://issues.apache.org/jira/browse/HDFS-4268 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.0.2-alpha > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Attachments: heartbeatHAState.patch > > > NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used > enum HAServiceState. > We should also consistently use HAServiceState to check if the state is > ACTIVE or STANDBY rather than using {{instanceof}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira