[ 
https://issues.apache.org/jira/browse/HDFS-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511011#comment-13511011
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4261:
----------------------------------------------

+1 patch looks good.

Balancer is a shell command so that it uses System.out/err directly.  It also 
has a LOG so that the log level can be changed.  We may want to carefully think 
about when to use System.out/err and when to use LOG for each message.  Let's 
don't change the messages here.  We may change them in another JIRA if it is 
desirable.

BTW, the test case is excellent!
                
> TestBalancerWithNodeGroup times out
> -----------------------------------
>
>                 Key: HDFS-4261
>                 URL: https://issues.apache.org/jira/browse/HDFS-4261
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer
>    Affects Versions: 1.0.4, 1.1.1, 2.0.2-alpha
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Junping Du
>         Attachments: HDFS-4261.patch, HDFS-4261-v2.patch, HDFS-4261-v3.patch
>
>
> When I manually ran TestBalancerWithNodeGroup, it always timed out in my 
> machine.  Looking at the Jerkins report [build 
> #3573|https://builds.apache.org/job/PreCommit-HDFS-Build/3573//testReport/org.apache.hadoop.hdfs.server.balancer/],
>  TestBalancerWithNodeGroup somehow was skipped so that the problem was not 
> detected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to