[ 
https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528590#comment-13528590
 ] 

Ivan Mitic commented on HDFS-4274:
----------------------------------

Thanks Chris for reporting the problem and for the patch! I also saw that 
something around DataBlockScanner causes many tests to fail.

Quick question, would it make sense to shutdown BlockPoolSliceScanners on 
DataBlockScanner#shutdown? In the current patch you are assuming that it is 
fine to close the verificationlogs when DataBlockScanner#run exits what might 
not be always true (don't know for sure, asking based on the class 
relationship). Just a thought, otherwise patch looks good.
                
> BlockPoolSliceScanner does not close verification log during shutdown
> ---------------------------------------------------------------------
>
>                 Key: HDFS-4274
>                 URL: https://issues.apache.org/jira/browse/HDFS-4274
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-4274.1.patch
>
>
> {{BlockPoolSliceScanner}} holds open a handle to a verification log.  This 
> file is not getting closed during process shutdown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to