[
https://issues.apache.org/jira/browse/HDFS-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540282#comment-13540282
]
Brandon Li commented on HDFS-4334:
----------------------------------
Thanks, Nicholas.
{quote}Change the INodeId class to package private.{quote}
Fixed.
{quote}Rewrite the javadoc of INodeId.LAST_RESERVED_ID. I think it is incorrect
to say that it is the first valid inode id.{quote}
Fixed.
{quote}Let's rename BOGUS_INODE_ID to GRANDFATHER_INODE_ID so that it uses the
same naming convention as GRANDFATHER_GENERATION_STAMP.{quote}
Updated.
{quote}Remove INodeId(long newValue). It is only used by the other
constructor.{quote}
Removed.
{quote}When edit log is empty (or no file/dir/symlink creation operations), the
lastInodeId in loadEditRecords(..) remains unchanged. However,
resetLastInodeId(..) may throw an exception since the newValue is not less than
getLastInodeId().{quote}
This is fine. resetLastInodeId() throws exception when newValue is less than
getLastInodeId().
I added more test steps to validate the empty editlog can be correctly handled.
> Add a unique id to each INode
> -----------------------------
>
> Key: HDFS-4334
> URL: https://issues.apache.org/jira/browse/HDFS-4334
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-4334.patch, HDFS-4334.patch, HDFS-4334.patch
>
>
> This JIRA is to track the task to add inode id, which is a 64bit number.
> Unlike many local file systems, HDFS doesn't recycle inode id.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
