[
https://issues.apache.org/jira/browse/HDFS-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542676#comment-13542676
]
Aaron T. Myers commented on HDFS-4306:
--------------------------------------
Hi Binglin, the patch looks functionally fine to me. My only comment is that
the two test methods introduced seem to duplicate a lot of code, and so could
be refactored easily to reduce the overlap.
+1 once that's addressed.
> PBHelper.convertLocatedBlock miss convert BlockToken
> ----------------------------------------------------
>
> Key: HDFS-4306
> URL: https://issues.apache.org/jira/browse/HDFS-4306
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.0.2-alpha
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Attachments: HDFS-4306.patch, HDFS-4306.v2.patch
>
>
> PBHelper.convertLocatedBlock(from protobuf array to primitive array) miss
> convert BlockToken.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
