[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543366#comment-13543366
]
Todd Lipcon commented on HDFS-4352:
-----------------------------------
{code}
+ public static class Params {
{code}
Need a Private annotation
{code}
+ @InterfaceAudience.LimitedPrivate("HDFS")
+ public static class Conf {
{code}
LimitedPrivate is meant for limited cross-project audience. In this case, the
code is in HDFS, so you should use just Private.
Otherwise looks good to me.
> Encapsulate arguments to BlockReaderFactory in a class
> ------------------------------------------------------
>
> Key: HDFS-4352
> URL: https://issues.apache.org/jira/browse/HDFS-4352
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 2.0.3-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: 01.patch
>
>
> Encapsulate the arguments to BlockReaderFactory in a class to avoid having to
> pass around 10+ arguments to a few different functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
