[ 
https://issues.apache.org/jira/browse/HDFS-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546428#comment-13546428
 ] 

Aaron T. Myers commented on HDFS-4035:
--------------------------------------

+1, patch looks good.
                
> LightWeightGSet and LightWeightHashSet increment a volatile without 
> synchronization
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-4035
>                 URL: https://issues.apache.org/jira/browse/HDFS-4035
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-4035.txt
>
>
> LightWeightGSet and LightWeightHashSet have a volatile modification field 
> that they use to detect updates while iterating so they can throw a 
> ConcurrentModificationException. Since these "LightWeight" classes are 
> explicitly "not thread safe" (eg access to their members is not synchronized) 
> then the current use is OK, we just need to update findbugsExcludeFile.xml to 
> exclude them.
>   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to