[ https://issues.apache.org/jira/browse/HDFS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547373#comment-13547373 ]
Hudson commented on HDFS-4034: ------------------------------ Integrated in Hadoop-trunk-Commit #3196 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3196/]) HDFS-4034. Remove redundant null checks. Contributed by Eli Collins (Revision 1430585) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1430585 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReplicaInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeResourceChecker.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java > Remove redundant null checks > ---------------------------- > > Key: HDFS-4034 > URL: https://issues.apache.org/jira/browse/HDFS-4034 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: 2.0.0-alpha > Reporter: Eli Collins > Assignee: Eli Collins > Fix For: 2.0.3-alpha > > Attachments: hdfs-4034.txt, hdfs-4034.txt > > > Findbugs 2 catches a number of places where we're checking for null in cases > where the value will never be null. > We might need to wait until we switch to findbugs 2 to commit this as the > current findbugs may not be so smart. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira