[ 
https://issues.apache.org/jira/browse/HDFS-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eli Collins updated HDFS-4032:
------------------------------

    Attachment: hdfs-4032.txt

Updated the patch.  The test failures were due to a missing flush in 
NamenodeWebHdfsMethods#getListingStream. Given that both the new PrintWriter 
like the old PrintStream does not auto flush, and that they are implemented 
similarly (the PrintStream was creating a OutputStreamWriter under the hood 
like we're doing here) the only difference I can see is a different buffering 
implementation tickling this. According to docs the StreamingOutput method 
created here should be flushing it's stream so I think the flush here was 
always needed, we've just gotten away with not having it so far. Also updated 
Journal.java which came in after the last patch as part of the QJM merge.
                
> Specify the charset explicitly rather than rely on the default
> --------------------------------------------------------------
>
>                 Key: HDFS-4032
>                 URL: https://issues.apache.org/jira/browse/HDFS-4032
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-4032.txt, hdfs-4032.txt
>
>
> Findbugs 2 warns about relying on the default Java charset instead of 
> specifying it explicitly. Given that we're porting Hadoop to different 
> platforms it's better to be explicit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to