[
https://issues.apache.org/jira/browse/HDFS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552122#comment-13552122
]
Hadoop QA commented on HDFS-1245:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12564601/blockIdGenerator-branch2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3831//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3831//console
This message is automatically generated.
> Plugable block id generation
> -----------------------------
>
> Key: HDFS-1245
> URL: https://issues.apache.org/jira/browse/HDFS-1245
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: namenode
> Affects Versions: 0.22.0
> Reporter: Dmytro Molkov
> Assignee: Konstantin Shvachko
> Fix For: 2.0.3-alpha
>
> Attachments: blockIdGenerator-branch2.patch, blockIdGenerator.patch
>
>
> The idea is to have a way to easily create block id generation engines that
> may fit a certain purpose. One of them could be HDFS-898 started by
> Konstantin, but potentially others.
> We chatted with Dhruba about this for a while and came up with the following
> approach:
> There should be a BlockIDGenerator interface that has following methods:
> void blockAdded(Block)
> void blockRemoved(Block)
> Block nextBlock()
> First two methods are needed for block generation engines that hold a certain
> state. During the restart, when namenode reads the fsimage it will notify
> generator about all the blocks it reads from the image and during runtime
> namenode will notify the generator about block removals on file deletion.
> The instance of the generator will also have a reference to the block
> registry, the interface that BlockManager implements. The only method there
> is __blockExists(Block)__, so that the current random block id generation can
> be implemented, since it needs to check with the block manager if the id is
> already present.
> What does the community think about this proposal?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
