[
https://issues.apache.org/jira/browse/HDFS-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555348#comment-13555348
]
Aaron T. Myers commented on HDFS-4409:
--------------------------------------
+1, patch looks good to me.
> FileSystemContractBaseTest should be less brittle in teardown
> -------------------------------------------------------------
>
> Key: HDFS-4409
> URL: https://issues.apache.org/jira/browse/HDFS-4409
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0, 1.1.2
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: HDFS-4409.patch
>
>
> the teardown code in FileSystemContractBaseTest assumes that {{fs!=null}} and
> that it's OK to throw an exception if the delete operation fails. Better to
> check the {{fs}} value and catch and convert an exception in the
> {{fs.delete()}} operation to a {{LOG.error()}} instead.
> This will stop failures in teardown becoming a distraction from the root
> causes of the problem (that your FileSystem is broken)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
