[ 
https://issues.apache.org/jira/browse/HDFS-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Li updated HDFS-4393:
-----------------------------

    Attachment: HDFS-4393.patch

Update the patch to address Suresh's comments.
                
> Empty request and responses in protocol translators can be static final 
> members
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-4393
>                 URL: https://issues.apache.org/jira/browse/HDFS-4393
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-4393.patch, HDFS-4393.patch, HDFS-4393.patch
>
>
> Some of the empty request and responses in protocol translators are 
> unnecessarily created every time. They can be static final members in the 
> translators. 
> Example: ClientNamenodeProtocolTranslatorPB.java
>     GetServerDefaultsRequestProto req = 
> GetServerDefaultsRequestProto.newBuilder().build();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to