[ 
https://issues.apache.org/jira/browse/HDFS-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556654#comment-13556654
 ] 

Aaron T. Myers edited comment on HDFS-4415 at 1/17/13 10:45 PM:
----------------------------------------------------------------

Hey Robert, patch looks pretty good to me. One suggestion: could we perhaps 
catch the more specific UnknownHostException instead of just Exception? You 
wouldn't want to catch and continue processing in the event of, for example, an 
NPE, I assume.
                
      was (Author: atm):
    Hey Robert, patch looks pretty good to me. One suggestion: could we perhaps 
the more specific UnknownHostException instead of just Exception? You wouldn't 
want to catch and continue processing in the event of , for example, an NPE, I 
assume.
                  
> HostnameFilter should handle hostname resolution failures and continue 
> processing
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-4415
>                 URL: https://issues.apache.org/jira/browse/HDFS-4415
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: HDFS-4415.patch, HDFS-4415.patch
>
>
> In {{HostnameFilter}}, if the remote address is NULL or the inet resolution 
> fails the request will never make it to the httpfs server.
> We should instead set the hostname to something like "???" and let the 
> processing continue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to