[ https://issues.apache.org/jira/browse/HDFS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560332#comment-13560332 ]
Jing Zhao commented on HDFS-4350: --------------------------------- The patch also looks good to me. One minor issue: the unused "import com.google.common.base.Preconditions;" can be removed from HeartbeatManager.java. > Make enabling of stale marking on read and write paths independent > ------------------------------------------------------------------ > > Key: HDFS-4350 > URL: https://issues.apache.org/jira/browse/HDFS-4350 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Andrew Wang > Assignee: Andrew Wang > Attachments: hdfs-4350-1.patch, hdfs-4350-2.patch, hdfs-4350-3.patch, > hdfs-4350-4.patch, hdfs-4350.txt > > > Marking of datanodes as stale for the read and write path was introduced in > HDFS-3703 and HDFS-3912 respectively. This is enabled using two new keys, > {{DFS_NAMENODE_CHECK_STALE_DATANODE_KEY}} and > {{DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_WRITE_KEY}}. However, there currently > exists a dependency, since you cannot enable write marking without also > enabling read marking, since the first key enables both checking of staleness > and read marking. > I propose renaming the first key to > {{DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_READ_KEY}}, and make checking enabled > if either of the keys are set. This will allow read and write marking to be > enabled independently. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira