[
https://issues.apache.org/jira/browse/HDFS-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565793#comment-13565793
]
Jing Zhao commented on HDFS-4447:
---------------------------------
The patch looks good to me. Some minors:
1. javadoc for two getINode() in SnapshotDiffList.java
2. We have DirectoryDiff, ChildrenDiff, Diff, SnapshotDiff, this is a little
bit hard to follow. How about some renaming like SnapshotDiffForDirectory,
SnapshotDiffForFile?
3. SnapshotDiff#combinePosterior(final D posterior, final BlocksMapUpdateInfo
collectedBlocks)
can be renamed to deletePosterior, or combineAndDeletePosterior, so as to
distinguish with Diff#combinePosterior?
> Refactor INodeDirectoryWithSnapshot for sharing the code with
> INodeFileWithSnapshot
> -----------------------------------------------------------------------------------
>
> Key: HDFS-4447
> URL: https://issues.apache.org/jira/browse/HDFS-4447
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4447_20130128.patch
>
>
> This is a code refactoring for HDFS-4446.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
