[ 
https://issues.apache.org/jira/browse/HDFS-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568056#comment-13568056
 ] 

Jing Zhao commented on HDFS-4189:
---------------------------------

+1 for the patch. Only a very minor issue: FSDirectory#getLastINodesInPath can 
be renamed to getLastINodeInPath.
                
> rename getter method getMutableX and getXMutable to getXAndEnsureMutable
> ------------------------------------------------------------------------
>
>                 Key: HDFS-4189
>                 URL: https://issues.apache.org/jira/browse/HDFS-4189
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: Snapshot (HDFS-2802)
>            Reporter: Brandon Li
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4189_20130130.patch
>
>
> The method names with the form "getMutableXxx" may be misleading.  Let's 
> rename them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to