[ https://issues.apache.org/jira/browse/HDFS-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569379#comment-13569379 ]
Hadoop QA commented on HDFS-4452: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567681/getAdditionalBlock.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3940//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3940//console This message is automatically generated. > getAdditionalBlock() can create multiple blocks if the client times out and > retries. > ------------------------------------------------------------------------------------ > > Key: HDFS-4452 > URL: https://issues.apache.org/jira/browse/HDFS-4452 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.0.2-alpha > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Priority: Critical > Attachments: getAdditionalBlock-branch2.patch, > getAdditionalBlock.patch, getAdditionalBlock.patch, getAdditionalBlock.patch, > TestAddBlockRetry.java > > > HDFS client tries to addBlock() to a file. If NameNode is busy the client can > timeout and will reissue the same request again. The two requests will race > with each other in {{FSNamesystem.getAdditionalBlock()}}, which can result in > creating two new blocks on the NameNode while the client will know of only > one of them. This eventually results in {{NotReplicatedYetException}} because > the extra block is never reported by any DataNode, which stalls file creation > and puts it in invalid state with an empty block in the middle. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira