[ 
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573027#comment-13573027
 ] 

Eli Collins commented on HDFS-4268:
-----------------------------------

HAServiceState has 3 states (active,standy,initializing) and 
NNHAStatusHeartbeat.State has 2 (active,standby). Previously we failed an 
assert when creating a NNHAStatusHeartbeat with the initializing state, now we 
permit it - intentional?
                
> Remove redundant enum NNHAStatusHeartbeat.State
> -----------------------------------------------
>
>                 Key: HDFS-4268
>                 URL: https://issues.apache.org/jira/browse/HDFS-4268
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.2-alpha
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 2.0.3-alpha
>
>         Attachments: heartbeatHAState.patch, heartbeatHAState.patch
>
>
> NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used 
> enum HAServiceState.
> We should also consistently use HAServiceState to check if the state is 
> ACTIVE or STANDBY rather than using {{instanceof}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to