[ 
https://issues.apache.org/jira/browse/HDFS-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584638#comment-13584638
 ] 

Aaron T. Myers commented on HDFS-4484:
--------------------------------------

The patch looks good to me. I confirmed that on gcc 4.6.3 libwebhdfs does not 
compile without this patch, and does compile with it.

To test this I also had to install libcurl4-openssl-dev and libjansson-dev to 
get this to compile at all, neither of which is documented in BUILDING.txt. 
Colin, mind documenting those dependencies in BUILDING.txt as well? This could 
be done as a separate JIRA if you'd prefer. Either way is fine by me.
                
> libwebhdfs compilation broken with gcc 4.6.2
> --------------------------------------------
>
>                 Key: HDFS-4484
>                 URL: https://issues.apache.org/jira/browse/HDFS-4484
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.4-beta
>         Environment: OpenSUSE 12.1, x86_64, gcc 4.6.2
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4484.001.patch
>
>
> libwebhdfs doesn't compile with gcc 4.6.2.
> {code}
> /home/cmccabe/hadoop1/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/test_libwebhdfs_ops.c:
>  In function ‘main’:
> /home/cmccabe/hadoop1/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/test_libwebhdfs_ops.c:260:9:
>  error: ‘for’ loop initial declarations are only allowed in C99 mode
> /home/cmccabe/hadoop1/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/test_libwebhdfs_ops.c:260:9:
>  note: use option -std=c99 or -std=gnu99 to compile your code
> /home/cmccabe/hadoop1/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/test_libwebhdfs_ops.c:284:13:
>  warning: format ‘%lld’ expects argument of type ‘long long int’, but 
> argument 3 has type ‘tOffset’ [-Wformat]
> /home/cmccabe/hadoop1/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/test_libwebhdfs_ops.c:285:13:
>  warning: format ‘%lld’ expects argument of type ‘long long int’, but 
> argument 3 has type ‘tOffset’ [-Wformat]
> /home/cmccabe/hadoop1/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/test_libwebhdfs_ops.c:308:17:
>  warning: format ‘%lld’ expects argument of type ‘long long int’, but 
> argument 3 has type ‘tOffset’ [-Wformat]
> /home/cmccabe/hadoop1/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/test_libwebhdfs_ops.c:309:17:
>  warning: format ‘%lld’ expects argument of type ‘long long int’, but 
> argument 3 has type ‘tOffset’ [-Wformat]
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to