[ https://issues.apache.org/jira/browse/HDFS-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584964#comment-13584964 ]
Hadoop QA commented on HDFS-4235: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12570577/HDFS-4235.002.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:red}-1 one of tests included doesn't have a timeout.{color} {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3999//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3999//console This message is automatically generated. > when outputting XML, OfflineEditsViewer can't handle some edits containing > non-ASCII strings > -------------------------------------------------------------------------------------------- > > Key: HDFS-4235 > URL: https://issues.apache.org/jira/browse/HDFS-4235 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.0.3-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HDFS-4235.001.patch, HDFS-4235.002.patch, > HDFS-4235.003.patch > > > It seems that when outputting XML, OfflineEditsViewer can't handle some edits > containing non-ASCII strings. > Example: > {code} > cmccabe@keter:/h> ./bin/hdfs oev -i ~/Downloads/current2/edits -o /tmp/u.xml > > 17:11:24,662 ERROR OfflineEditsBinaryLoader:82 - Got IOException at position > 10593 > Encountered exception. Exiting: SAX error: The character '�' is an invalid > XML character > java.io.IOException: SAX error: The character '�' is an invalid XML character > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.XmlEditsVisitor.visitOp(XmlEditsVisitor.java:119) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsBinaryLoader.loadEdits(OfflineEditsBinaryLoader.java:78) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer.go(OfflineEditsViewer.java:142) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer.run(OfflineEditsViewer.java:228) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) > at > org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer.main(OfflineEditsViewer.java:237) > {code} > Probably, we forgot to properly escape and/or re-encode a filename before > putting it into the XML. The other processors (stats, binary) don't have > this problem, so it is purely an XML encoding issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira