[
https://issues.apache.org/jira/browse/HDFS-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585502#comment-13585502
]
Suresh Srinivas commented on HDFS-4479:
---------------------------------------
+1 for the patch. Thanks for not indenting the try block to make the review
easy. I am going to indent it before committing the code.
> In branch-1, logSync() may be called with the FSNamesystem lock held in
> commitBlockSynchronization
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-4479
> URL: https://issues.apache.org/jira/browse/HDFS-4479
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-4479.b1.001.patch, HDFS-4479.b1.002.patch
>
>
> In FSNamesystem#commitBlockSynchronization of branch-1, logSync() may be
> called when the FSNamesystem lock is held. Similar with HDFS-4186, this may
> cause some performance issue.
> Since logSync is called right after the synchronization section, we can
> simply remove the logSync call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
