[ https://issues.apache.org/jira/browse/HDFS-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594203#comment-13594203 ]
Hadoop QA commented on HDFS-4544: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572199/HDFS-4544.trunk.1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4042//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4042//console This message is automatically generated. > Error in deleting blocks should not do check disk, for all types of errors > -------------------------------------------------------------------------- > > Key: HDFS-4544 > URL: https://issues.apache.org/jira/browse/HDFS-4544 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 1.1.1, 2.0.3-alpha > Reporter: Amareshwari Sriramadasu > Assignee: Arpit Agarwal > Fix For: 1.2.0, 3.0.0 > > Attachments: HDFS-4544.branch-1.1.patch, HDFS-4544.patch, > HDFS-4544.trunk.1.patch > > > The following code in Datanode.java > {noformat} > try { > if (blockScanner != null) { > blockScanner.deleteBlocks(toDelete); > } > data.invalidate(toDelete); > } catch(IOException e) { > checkDiskError(); > throw e; > } > {noformat} > causes check disk to happen in case of any errors during invalidate. > We have seen errors like : > 2013-03-02 00:08:28,849 WARN org.apache.hadoop.hdfs.server.datanode.DataNode: > Unexpected error trying to delete block blk_-2973118207682441648_225738165. > BlockInfo not found in volumeMap. > And all such errors trigger check disk, making the clients timeout. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira